Skip to content

Feat/add via barcode scan field#11

Merged
dvdl16 merged 4 commits into
version-15from
feat/add_via_barcode_scan_field
Jun 5, 2026
Merged

Feat/add via barcode scan field#11
dvdl16 merged 4 commits into
version-15from
feat/add_via_barcode_scan_field

Conversation

@Starktail-Christo

@Starktail-Christo Starktail-Christo commented Jun 4, 2026

Copy link
Copy Markdown

Description

Add field that allows users to add items to Cart using barcode scanning

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tests

  • Unit Tests have been updated or added, as required
  • UI Tests have been updated or added, as required

Checklist:

  • My code follows Naming Guidelines (DocType, Field and Variable naming)
  • No Form changes / My code follows the Form Design Guidelines
  • My code follows the Coding Standards of this project
  • My code follows the Code Security Guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas / No comments necessary
  • I have made corresponding additions/changes to the documentation
  • All business logic and validations are on the server-side / No business logic or validation changes
  • No patches are necessary / Migration Patches have been added to the correct subdirectory of /patches and patches.txt have been updated

User Experience:

Scan Barcode

@Starktail-Christo Starktail-Christo marked this pull request as ready for review June 4, 2026 06:25
@Starktail-Christo Starktail-Christo requested a review from dvdl16 June 4, 2026 06:26

@dvdl16 dvdl16 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom_add_via_barcode_scan should also have an entry in the fixtures block in hooks.py?

@Starktail-Christo

Copy link
Copy Markdown
Author

@dvdl16
The previous author included the POSNext module as a custom_field filter, that covers all new custom_fields.
For me to move this to a per field hook, I would need to change about 60 fields.

This does require some cleanup in a future pull request
image

@dvdl16 dvdl16 merged commit de00414 into version-15 Jun 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants